fix(sdk): carry API key on execd requests per use_server_proxy declaration - #1687
Merged
Pangjiping merged 2 commits intoSep 4, 2026
Merged
Conversation
…ation Multi-tenant servers authenticate the proxy route too, but execd adapters sent no API key — Sandbox.connect() surfaced the 401 as a 30s timeout. Attach the key only when the client declared proxy mode; in direct mode it must never travel into the untrusted sandbox. Fixes opensandbox-group#1686
jiawen7777
requested review from
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
August 31, 2026 15:57
github-actions
Bot
added
sdk/python
size/L
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 824254411d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HealthAdaptermissing authentication headers whenuse_server_proxy=True, causing health check to always fail with 401 #248)Sandbox.connect()surfaced the 401 as a 30s health-check timeout.SandboxEndpoint.build_request_headers()is now the shared header assembly used by all 14 execd adapters (async + sync). The key is attached only when the client declared server-proxy mode (ConnectionConfig.use_server_proxy); in direct mode the key is never sent — execd performs no auth and the key must not travel into the untrusted sandbox.Testing
6 new tests in
tests/test_execd_proxy_auth_headers.pylock: declared proxy → key attached regardless of endpoint URL shape; direct mode → key never attached; no key configured → header omitted (async + sync). Full SDK suite,ruff check, andpyrightall pass.e2e: verified against a multi-tenant deployment — without the fix
connect()fails after 30s withSandboxReadyTimeoutExceptionwhile the server logs401 MISSING_API_KEYon the proxy health route; with the fixconnect()succeeds in <1s and commands/files work with no workaround.Breaking Changes
Checklist
use_server_proxy=True; single-tenant deployments unaffected (server already exempts proxy paths per fix(server): skip auth for proxy-to-sandbox paths; strict path matching #250)